Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quote)!: remove internal fields from schema #2858

Merged
merged 8 commits into from
Aug 20, 2024
Merged

feat(quote)!: remove internal fields from schema #2858

merged 8 commits into from
Aug 20, 2024

Conversation

golobitch
Copy link
Collaborator

@golobitch golobitch commented Aug 11, 2024 •
edited
Loading

Changes proposed in this pull request

  • Remove internal fields from quote schema

Context

fixes #2856

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@golobitch golobitch self-assigned this Aug 11, 2024
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: mock-account-service-lib labels Aug 11, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 11, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 2886357
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66c39a43cc704b00081b72f3

@golobitch golobitch changed the title Feature/2856 create quote response feature(quote): remove internal fields from schema Aug 11, 2024
@golobitch golobitch changed the title feature(quote): remove internal fields from schema feat(quote): remove internal fields from schema Aug 11, 2024
@golobitch golobitch force-pushed the feature/2856-create-quote-response branch from a2e4352 to 77a0606 Compare August 11, 2024 14:47
@golobitch golobitch marked this pull request as draft August 11, 2024 19:42
@golobitch golobitch removed the request for review from mkurapov August 11, 2024 19:43
@golobitch golobitch force-pushed the feature/2856-create-quote-response branch 3 times, most recently from 69b4dd2 to 1681d8a Compare August 11, 2024 21:06
@golobitch golobitch force-pushed the feature/2856-create-quote-response branch from dbd2fba to df7764d Compare August 15, 2024 11:34
@golobitch golobitch force-pushed the feature/2856-create-quote-response branch from df7764d to 0563339 Compare August 15, 2024 11:56
@golobitch golobitch marked this pull request as ready for review August 15, 2024 12:05
BlairCurrey
BlairCurrey reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@BlairCurrey BlairCurrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 item to change https://github.com/interledger/rafiki/pull/2858/files#r1718632922, otherwise looks good

@golobitch golobitch force-pushed the feature/2856-create-quote-response branch from 1db9320 to a78a4be Compare August 16, 2024 20:04
@golobitch
Copy link
Collaborator Author

1 item to change https://github.com/interledger/rafiki/pull/2858/files#r1718632922, otherwise looks good

Yes, my bad. I reverted that file.

BlairCurrey
BlairCurrey previously approved these changes Aug 19, 2024
View reviewed changes
mkurapov
mkurapov reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to edit some bruno requests

bruno/collections/Rafiki/Rafiki Admin APIs/Cancel Outgoing Payment.bru Show resolved Hide resolved
@golobitch golobitch merged commit 8e96bc3 into main Aug 20, 2024
42 checks passed
@golobitch golobitch deleted the feature/2856-create-quote-response branch August 20, 2024 14:07
@golobitch golobitch changed the title feat(quote): remove internal fields from schema feat(quote)!: remove internal fields from schema Aug 20, 2024
@mkurapov mkurapov added the breaking Issue/PR that introduces breaking changes label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

@BlairCurrey BlairCurrey BlairCurrey approved these changes

Assignees

@golobitch golobitch

Labels
breaking Issue/PR that introduces breaking changes pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the createQuote mutation response type
3 participants
@golobitch @BlairCurrey @mkurapov